vdiffr icon indicating copy to clipboard operation
vdiffr copied to clipboard

R-devel issues (R > 4.1)

Open pat-s opened this issue 4 years ago • 8 comments

We see these issues on R-devel (R-release, 4.1.1 is fine).

Reading all the threads about R-devel related issues, I suspsect there might be new trouble eventually? In #86 the changes were announced for R 4.1 but now were on the way to 4.2, so the discussion in #86 might not apply anymore?

pat-s avatar Oct 05 '21 18:10 pat-s

Thanks for the heads up.

Hopefully we will be able to leverage the new "variant" snapshots of the recent testthat release: https://www.tidyverse.org/blog/2021/10/testthat-3-1/#snapshot-tests

lionel- avatar Oct 05 '21 20:10 lionel-

~~Since R 4.2 release is only a few days away now, I was wondering if there are any updates on this issue.~~

Actually, the tests run just fine on R 4.2, so can't reproduce this issue, at least not for my tests.

IndrajeetPatil avatar Mar 27 '22 12:03 IndrajeetPatil

Hi @lionel-

Do you have any plans to reintroduce the unit testing mechanism in this package? Currently, the testing suite is only run for R below 4.1.0

maksymiuks avatar Sep 12 '22 14:09 maksymiuks

I think it's only run for R equal or above 4.1.0.

lionel- avatar Sep 12 '22 14:09 lionel-

They are not, at least according to my experience. Looking at the testthat.R content they were turned off roughly 2 years ago:

https://github.com/r-lib/vdiffr/blob/main/tests/testthat.R#L2-L6

so for instance tools::testInstalledPackage runs them only for R below 4.1.0. Tested it also locally on R 4.1.3 and 4.2.1

maksymiuks avatar Sep 12 '22 14:09 maksymiuks

oh you mean vdiffr

lionel- avatar Sep 12 '22 15:09 lionel-

Oh, pardon me @lionel- now I see I must have misinterpreted the matter of this issue. I apologize. Want me to migrate it to a new, appropriate one?

maksymiuks avatar Sep 12 '22 16:09 maksymiuks

It's alright we can keep track of this here, thanks!

lionel- avatar Sep 12 '22 19:09 lionel-