vctrs icon indicating copy to clipboard operation
vctrs copied to clipboard

test-partial-factor fails on big-endian machines

Open QuLogic opened this issue 3 years ago • 2 comments

... because rlang::hash is not endian-safe, unlike digest::digest was:

Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  `new`: "partial_factor<" "  fa16b {partial}" ">"
  ── Failure (test-partial-factor.R:10:3): has ok print method ───────────────────
  Results have changed from known value recorded in 'test-partial-factor-print-both.txt'.
  
  `old`: "partial_factor<" "  bf275 {partial}" "  fd1ad" ">"
  `new`: "partial_factor<" "  fa16b {partial}" "  31927" ">"
  ── Failure (test-partial-factor.R:22:3): has ok print method ───────────────────
  Results have changed from known value recorded in 'test-partial-factor-print-learned.txt'.
  
  `old`: "partial_factor<" "  fd1ad" ">"
  `new`: "partial_factor<" "  31927" ">"
  
  [ FAIL 5 | WARN 0 | SKIP 34 | PASS 4128 ]
  Error: Test failures
  Execution halted

QuLogic avatar Apr 06 '21 06:04 QuLogic

We don't support big endian platforms at this time.

hadley avatar Apr 06 '21 12:04 hadley

I will just skip the test then; do you want a PR to do so? (Though note, everything pass tests on big endian otherwise, even this one when it used to use digest.)

QuLogic avatar Apr 07 '21 00:04 QuLogic

If that helps you're welcome to send a PR to skip tests failing on big endian.

lionel- avatar Sep 12 '22 20:09 lionel-