testthat icon indicating copy to clipboard operation
testthat copied to clipboard
verified publisher icon r-lib

Snapshot failures should not count in max number of failures allowed

Open lionel- opened this issue 3 years ago • 1 comments

Otherwise we need to set TESTTHAT_MAX_FAILS to Inf to update all snapshots in one go.

lionel- avatar Sep 21 '22 07:09 lionel-

Somewhat related to https://github.com/r-lib/testthat/issues/1402 where we at least allowed the current test file to finish running so you could update snaps for that file and then rerun

DavisVaughan avatar Sep 21 '22 18:09 DavisVaughan

I've spent some time on this workflow in the past, and I think what we have currently isn't too bad. If you have a bunch of snapshot failure, you'll get the clickable "Set TESTTHAT_MAX_FAILS" error, and then you just re-run.

hadley avatar Mar 23 '23 13:03 hadley