scales icon indicating copy to clipboard operation
scales copied to clipboard

Consider including package name in S3 class name(s)?

Open rogiersbart opened this issue 1 year ago • 0 comments
trafficstars

Since the renaming of the {scales} S3 class to "transform", it clashes with e.g. {raylibr}'s S3 class. The print() method is defined in both packages, and generates a warning, but certain methods from {raylibr} not defined in {scales}, break {scales} and therefore {ggplot2}. In the reprex below, in particular, S3method("$",transform) from {raylibr} is responsible. I realize that clashes with non-CRAN packages may be considered not very important, but the problem could be a lot bigger I suppose, as "transform" is a rather generic name, and it seems to be recommended to include the package name in S3 class names (well, at least according to Advanced R). Maybe it would be useful to consider including the package name in the S3 class names? FYI, I submitted the same suggestion at jeroenjanssens/raylibr#13.

library(raylibr)
#> 
#> Attaching package: 'raylibr'
#> The following object is masked from 'package:base':
#> 
#>     transform
library(ggplot2)
#> Registered S3 method overwritten by 'scales':
#>   method          from   
#>   print.transform raylibr
ggplot2::ggplot(cars) +
  ggplot2::aes(speed, dist) +
  ggplot2::geom_point()
#> Error:
#> ! `transform` has no property transform.

Created on 2024-05-08 with reprex v2.1.0

rogiersbart avatar May 08 '24 12:05 rogiersbart