rlang icon indicating copy to clipboard operation
rlang copied to clipboard

C internal errors are broken with rlang 1.0.3

Open DavisVaughan opened this issue 1 year ago • 2 comments

library(vctrs)
vec_rbind(new_data_frame(list(x=NULL)))

With rlang 1.0.2:

Error in `vec_rbind()`:
! Unexpected `NULL`.
ℹ In file slice.c at line 322.
ℹ This is an internal error in the rlang package, please report it to the
  package authors.

With rlang 1.0.3:

Error in if (error_frame) { : argument is not interpretable as logical
In addition: Warning message:
In if (error_frame) { :
  the condition has length > 1 and only the first element will be used

Note that you have to run the code interactively. I tried to do a reprex and it "worked" in that case.

DavisVaughan avatar Jul 05 '22 21:07 DavisVaughan

Upstream issue: https://github.com/r-prof/winch/issues/56.

This seems like a brittle aspect of entracing. I'm considering to stop enabling winch for internal errors.

lionel- avatar Aug 16 '22 14:08 lionel-

I'll move winch_add_trace_back() to rlang, requires winch >= 0.1.0 .

krlmlr avatar Apr 19 '23 13:04 krlmlr