pkgdown icon indicating copy to clipboard operation
pkgdown copied to clipboard
verified publisher icon r-lib

Custom navbar config needs to reference the search bar

Open maelle opened this issue 1 year ago • 3 comments

it used not to, the change is due to #2449

https://mastodon.social/@sebffischer/112954449837337953

maelle avatar Aug 19 '24 10:08 maelle

Do you mean that previously if you had a custom navbar config but didn't include search, it would be included in the navbar anyway? If so, then the new behavior is actually more consistent with the documentation. Bummer it affects lots of sites though.

FWIW this was an unintentional "fix".

Can you link to a site that was affected by this change?

jayhesselberth avatar Aug 19 '24 11:08 jayhesselberth

Do you mean that previously if you had a custom navbar config but didn't include search, it would be included in the navbar anyway?

yes!

One example: https://github.com/ropensci/targets/pull/1303/files (more linked from https://github.com/ropensci-org/rotemplate/issues/112)

maelle avatar Aug 19 '24 11:08 maelle

I knew this was going to happen so I must have failed to advertise it enough 😞

hadley avatar Aug 19 '24 14:08 hadley