pillar icon indicating copy to clipboard operation
pillar copied to clipboard

Add option to suppress hints

Open krlmlr opened this issue 1 year ago • 2 comments

e.g. ℹ Use `print(n = ...)` to see more rows .

CC @juliasilge.

krlmlr avatar Jul 28 '22 01:07 krlmlr

Should it be off by default in non-interactive environments?

krlmlr avatar Jul 28 '22 01:07 krlmlr

I think so, it would be awkward to have to show the code to turn them off in slides. And doing it with some global options can also get confusing for people seeing what's on slides and seeing their output doesn't exactly match up.

mine-cetinkaya-rundel avatar Jul 28 '22 01:07 mine-cetinkaya-rundel

I would really like to have any changes to tibbles vetted in the tidyverse meeting. This is wreaking havoc with snapshots and adding unicode characters to our Rd files (which requires me to figure out and do a parsnip submission).

The printing matters and we need more oversight on changes. I didn't seen anything about this in news files either.

(edit for spelling)

topepo avatar Aug 16 '22 15:08 topepo

Yes, should definitely be turned off interactively, and we should offer an option to globally suppress. @krlmlr could you please try and priortise this?

hadley avatar Aug 16 '22 15:08 hadley

An option to turn it off entirely would be good too. The 'ℹ' adds unicode to our Rd files and, for slides, it eats up one more row of output.

topepo avatar Aug 17 '22 12:08 topepo

Taking a look now.

krlmlr avatar Aug 17 '22 17:08 krlmlr

Apologies for the trouble it causes, waiting until after the conf would have been better here.

Updated the NEWS file.

krlmlr avatar Aug 17 '22 17:08 krlmlr

Does #577 work for you? I can push a fix to CRAN tomorrow.

krlmlr avatar Aug 17 '22 18:08 krlmlr

In the main branch now, does it work for you? Is the option name "pillar.advice" good?

krlmlr avatar Aug 18 '22 02:08 krlmlr

Thanks for working on this! Option name sounds good to me.

hadley avatar Aug 18 '22 11:08 hadley

pillar 1.8.1 on CRAN now.

krlmlr avatar Aug 19 '22 08:08 krlmlr

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

github-actions[bot] avatar Aug 20 '23 01:08 github-actions[bot]