pak icon indicating copy to clipboard operation
pak copied to clipboard

Should `Failed to download {pkg}` fail immediately?

Open DavisVaughan opened this issue 1 year ago • 0 comments

https://github.com/tidyverse/dplyr/actions/runs/3420263220/jobs/5694855875#step:5:3380

As part of this run, you can see this message

✖ Failed to download rcmdcheck 1.4.0 (source)

But it doesn't stop there, the installation process continues and we finally get an obscure error here:

 ℹ Building rcmdcheck 1.4.0
  
  Error: Error: <callr_remote_error: `path` must exist>
   in process 9537 
  -->
  <simpleError: `path` must exist>
  
   Stack trace:
  
   12. (function (...)  ...
   13. base:::withCallingHandlers(cli_message = function(msg) { ...
   14. get("lockfile_install_internal", asNamespace("pak"))(...)
   15. plan$install()
   16. pkgdepends:::install_package_plan(plan, lib = private$library,  ...
   17. base:::withCallingHandlers({ ...
   18. pkgdepends:::start_task(state, task)
   19. pkgdepends:::start_task_build(state, task)
   20. pkgdepends:::make_build_process(path, pkg, tmp_dir, lib, vignettes,  ...
   21. withr::with_libpaths(c(tmplib, lib), action = "prefix", pkgbuild_process$ne ...
   22. base:::force(code)
   23. pkgbuild_process$new(path, tmp_dir, binary = binary, vignettes = vignettes, ...
   24. pkgbuild:::initialize(...)
   25. pkgbuild:::rcb_init(self, private, super, path, dest_path, binary,  ...
   26. pkgbuild:::build_setup(path, dest_path, binary, vignettes, manual,  ...
   27. base:::stop("`path` must exist", call. = FALSE)
   28. base:::.handleSimpleError(function (e)  ...
   29. h(simpleError(msg, call))
   30. base:::stop(e)
   31. (function (e)  ...
  
   x `path` must exist 

We wondered if possibly this should have exited earlier when the package couldn't be downloaded

DavisVaughan avatar Nov 08 '22 14:11 DavisVaughan