memoise icon indicating copy to clipboard operation
memoise copied to clipboard

Add postgresql backend

Open mattyb opened this issue 6 years ago • 2 comments

This PR creates a PostgreSQL backend for memoise

mattyb avatar Feb 13 '19 22:02 mattyb

Codecov Report

Merging #82 into master will decrease coverage by 8.5%. The diff coverage is 89.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   77.37%   68.86%   -8.51%     
==========================================
  Files           5        6       +1     
  Lines         221      318      +97     
==========================================
+ Hits          171      219      +48     
- Misses         50       99      +49
Impacted Files Coverage Δ
R/cache_postgresql.R 89.69% <89.69%> (ø)
R/cache_s3.R 0% <0%> (-100%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1650ad7...86c6a6c. Read the comment docs.

codecov-io avatar Feb 13 '19 22:02 codecov-io

Is there a reason you used RPostgreSQL for this instead of RPostgres? Also rather than a postgres specific database maybe it would make more sense to use the odbc package, so any odbc-compliant database could be used?

jimhester avatar Mar 04 '20 13:03 jimhester