gargle icon indicating copy to clipboard operation
gargle copied to clipboard

gargle:::secret_pw_name generates names that are invalid to serve as repository var on GitHub.

Open harell opened this issue 3 years ago • 0 comments

  • Github secret names can only contain alphanumeric characters ([a-z], [A-Z], [0-9]) or underscores (_)
  • R package names cannot contain underscores (_), but can contain dots (.)
  • Some R packages names use a dot (.) to separate between words, for example github.observatory
  • In the case of github.observatory, gargle:::secret_pw_name returns GITHUB.OBSERVATORY_PASSWORD.
  • Passing GITHUB.OBSERVATORY_PASSWORD as a Github secret name prompts the following error: image

One suggestion is to make standardise R packages names such that dots are replaced with underscores. For example, gargle:::secret_pw_name(github.observatory) will return GITHUB_OBSERVATORY_PASSWORD instead of GITHUB.OBSERVATORY_PASSWORD

harell avatar Apr 15 '22 00:04 harell