crayon

crayon copied to clipboard

crayon doesn't mark encoding on UTF-8 strings in some cases

2

For example: ``` library(crayon) text crayon::white(text) [1] "\033[37m你好\033[39m" > crayon::white(crayon::white(text)) [1] "\033[37m\033[37mä½ å¥½\033[37m\033[39m" ``` Note that the text 你好 in the second example is no longer encoded correctly. ``` >...

kevinushey

The `comment = ";"` in: https://github.com/r-lib/crayon/blob/77e5d9069a2c231f20d694209885b8f95665eb67/R/ansi-palette.R#L91-L102 should be `comment.char = ";"`. Got a warning about this during package installation; ``` * installing *source* package ‘crayon’ ... ** package ‘crayon’ successfully...

HenrikBengtsson

Prepare for release: * [x] `git pull` * [x] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_crayon.html) * [x] [Polish NEWS](https://style.tidyverse.org/news.html#news-release) * [x] `urlchecker::url_check()` * [x] `devtools::check(remote = TRUE, manual = TRUE)` *...

gaborcsardi

> Using @docType package no longer automatically adds a -package alias. > Instead document _PACKAGE to get all the defaults for package > documentation.

gaborcsardi