cli icon indicating copy to clipboard operation
cli copied to clipboard

cli vignettes could now rely on downlit

Open hadley opened this issue 4 years ago • 5 comments

Instead of using asciicast.

hadley avatar Apr 26 '21 21:04 hadley

That would be great, to avoid the images.

But then there'll be no colors and font styles in the README. Plus asciicast supports animations, and there will a lot more of those once the progress bar support is merged.

gaborcsardi avatar Apr 27 '21 10:04 gaborcsardi

Yeah, I was thinking you'd still use that in the README. And for animations, but you no longer have to use asciicast everywhere.

hadley avatar Apr 27 '21 11:04 hadley

That's possible, with the caveat that it would look slightly different in the README and for animations. I'll take a look before the next release.

gaborcsardi avatar Apr 27 '21 11:04 gaborcsardi

It would be considerable effort to match the themes, so they look similar, and also to refactor the article code, so that the animations are created in a background process, but the static output is not.

cli does not have any vignettes now, only articles, there are no images in the R package.

So the benefits are little, and the effort would be considerable, so if you don't mind, I'll not do this now.

gaborcsardi avatar Sep 18 '21 12:09 gaborcsardi

Yeah, no rush. It's not that important.

hadley avatar Sep 20 '21 12:09 hadley