archive icon indicating copy to clipboard operation
archive copied to clipboard

archive_write_files stores files with CRLF-LF coverted on Windows, resulting in corrupted archive

Open cielavenir opened this issue 11 months ago • 1 comments

because O_BINARY needs to be passed to open().

I have already proposed https://github.com/r-lib/archive/pull/80 but it was rejected.

See 65a54eb581a7968820fa33ad60bb955b0ab68f7f test for how to reproduce the issue.

cielavenir avatar Mar 18 '24 00:03 cielavenir

alternative solution to use #define O_BINARY https://github.com/r-lib/archive/pull/99

cielavenir avatar Mar 18 '24 01:03 cielavenir