Fix archive_write_files on Windows (add zip extract test)

[cielavenir]

This temporal pull request simply adds zip version of "can strip components if desired" test, but it raises "4821 in central directory, 4972 in local header" on Windows. It is not related to password, so super-strange.

Could you take a look? @gaborcsardi

[cielavenir]

calling archive_write_close is not sufficient

[gaborcsardi]

@cielavenir Thanks, I can take a look later today.

[cielavenir]

The thing is, is my library usage is wrong or is there potential problem on this library?

[cielavenir]

Hello @gaborcsardi , it turned out that open() argument requires O_BINARY on Windows. I have not checked in detail but it is possible that on Windows archive_write_files would not be working from the beginning.

I added integrity check to avoid this kind of accident further.

[cielavenir]

Simply adding integrity check to tar failed as https://github.com/r-lib/archive/actions/runs/4074516161 This means tar content was corrupted.

[cielavenir]

now it is ready.

[cielavenir]

hi, is cf0b568 good or still bad

[gaborcsardi]

I think it is good.

[cielavenir]

I don't think there are remaining issue here

[cielavenir]

are there still anything interfering merging?

[cielavenir]

This one should be ready, could you merge or are there any issues?

[cielavenir]

I'm tired, converted to issue https://github.com/r-lib/archive/issues/98

[cielavenir]

alternatively we can use #ifndef O_BINARY