actions icon indicating copy to clipboard operation
actions copied to clipboard

Upload of artifacts fails when working-directory is set for check-r-package

Open AskPascal opened this issue 2 years ago • 3 comments

Describe the bug We are using the check-r-package action in a workflow to check a package in a sub-directory of the repository with the help of the working-directory input. A failed check will not generate artifacts but instead leads to the warning "No files were found with the provided path: check. No artifacts will be uploaded." The same behaviour is seen both when the input check-dir is set and when it is not specified.

To Reproduce Run log: https://github.com/Olink-Proteomics/OlinkRPackage/actions/runs/2972694134

Expected behavior If the working-directory input is set it should be propagated to the artifact step.

Additional context I suspect that adding working-directory here: https://github.com/r-lib/actions/blob/cc43801a5c7c7730c2bb132cc3b245281df03764/check-r-package/action.yaml#L38 might be working

AskPascal avatar Sep 01 '22 15:09 AskPascal

Can you use OlinkAnalyze/check in check-dir here? https://github.com/Olink-Proteomics/OlinkRPackage/actions/runs/2972694134/workflow#L59

gaborcsardi avatar Sep 01 '22 15:09 gaborcsardi

I tried that now. Did not solve the problem. It was running the checks in the OlinkAnalyze/OlinkAnalyze/check directory then:

https://github.com/Olink-Proteomics/OlinkRPackage/runs/8151753999?check_suite_focus=true#step:6:51

AskPascal avatar Sep 02 '22 08:09 AskPascal

@gaborcsardi , @AskPascal, I looked at this as a follow-up on similar aspects I contributed to earlier this month/year (#560, #595), see commits above replicating the issue (even in conjunction with a custom check-dir) and testing a possible fix, for which I will soon have a PR ready.

riccardoporreca avatar Sep 05 '22 18:09 riccardoporreca

Fixed by #615.

gaborcsardi avatar Oct 20 '22 08:10 gaborcsardi

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

github-actions[bot] avatar Nov 04 '22 13:11 github-actions[bot]