rhub icon indicating copy to clipboard operation
rhub copied to clipboard

Consistency: Plural/Singular in platform argument

Open datawookie opened this issue 3 years ago • 1 comments
trafficstars

Hi!

Love this package. But just noticed an inconsistency:

  • in rhub::check() there's a platform (singular) argument but
  • in rhub::check_for_cran() it's called platforms (plural).

It seems that the latter is more appropriate since rhub::check() accepts a vector of values for platform. Is this intentional?

I'd be happy to fix this and create a PR. Just wanted to check first whether this was a design decision.

Thanks, Andrew.

datawookie avatar Dec 03 '21 17:12 datawookie

They both accept vectors, actually, and yeah, it is not great that they are not consistent. Strictly speaking this would be a breaking change, but I think we can fix it, and change it to platforms in check().

This way if people have code that uses platform, it will still work with partial matching.

Thank you for the PR offer. :)

gaborcsardi avatar Dec 03 '21 17:12 gaborcsardi