rhub icon indicating copy to clipboard operation
rhub copied to clipboard

Add the enviromental variable to check for URIs.

Open llrs opened this issue 3 years ago • 1 comments

This should close #401 couldn't test (and saw no formal test for check_for_cran that could modify and adapt).

llrs avatar Jul 28 '20 08:07 llrs

Codecov Report

Merging #403 (38b23b7) into master (10449c1) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 38b23b7 differs from pull request most recent head 8a6cb4b. Consider uploading reports for the commit 8a6cb4b to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          26       26           
  Lines         892      892           
=======================================
  Hits          250      250           
  Misses        642      642           
Impacted Files Coverage Δ
R/check-cran.R 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10449c1...8a6cb4b. Read the comment docs.

codecov-commenter avatar Jul 28 '20 08:07 codecov-commenter

Thanks! We definitely need to improve this, but hardwiring the values into the package does not seem optimal to me.

gaborcsardi avatar Aug 31 '22 11:08 gaborcsardi

Indeed, I tried a couple of weeks ago to update the PR with the values used by CRAN but it is not as simple as just reading a file.

llrs avatar Aug 31 '22 12:08 llrs