r-hang

Results 42 comments of r-hang

Hey @SpencerC, thanks for the contribution and sorry for the delay. While I understand that the go-cmp library has lots of users and powerful features, I think that having this...

Hey @SpencerC, I'm personally open to using wrapper type analogs for go-cmp options, I think that's more favorable than vendoring go-cmp in. Instead of initially adding 8 options, I think...

This is an understandable request. We are currently looking into whether or not the form of this feature should be a new top-level matcher or an option or change in...

@mtoader, would you be able to provide a repro example and an error message for the situation?

Sorry for the delay and thank you for the repro. I'm starting to take a look now, i'll have an update by Monday.

Hey @mtoader, I think the cause of this issue has to do with mockgen's attempt to merge all the files of a package with [ast.MergepackageFiles](https://github.com/uber-go/mock/blob/main/mockgen/parse.go#L270) before parsing it for imports....

Hey @mtoader sorry for the delay. Let's merge https://github.com/uber-go/mock/pull/165/files because it fixes what looks like a mistake where definedImports is never indexed by the importpath it is actually populated with....

Hey @thediveo, Thank you for filing the issue. My understanding of the issue is that gomock queue will queue expectations by normal means. Under `WithOverridableExpectations`, this queuing behavior stops and...

Hey, thanks for filing this issue. From my understanding of this ask, it's to enable a "raw copy" of content as the header since yours is already commented. Since we...

I think I understand why this could reduce some hand-written function declarations if you wanted to re-use setup functions but it think that having multiple patterns for setting up mocks...