Raghuveer Devulapalli

Results 122 comments of Raghuveer Devulapalli

> FYI you can set `HWY_BASELINE_TARGETS` to your desired target e.g., (HWY_AVX3|HWY_AVX2|HWY_SSE4|HWY_EMU128), to override Highway's detection based on compiler flags. can someone please remind why we need to use these?

> I think the reason is that Highway defaults to using whatever the build flags say to use. It is possibly easier to just set HWY_AVX2 than to set the...

I can take a look at the exact ULP error when I have access to a computer sometime next week. But for the example you provided, the output of v1.21...

Would it make sense to add an argument to transcendental functions for users to specify accuracy they want? Something like `np.log(arr, accuracy='high') `

@xkszltl not at the moment. https://github.com/numpy/numpy/issues/22904#issuecomment-1369702249 is still the work around.

> Please add a benchmark for the tanh activation function in onnxruntime/test/mlas/bench/. There is already a benchmark for tanhf `BM_Tanh`. Is this not sufficient? https://github.com/microsoft/onnxruntime/blob/69cfcba38a60d65498f94cde30cb9c2030f7255b/onnxruntime/test/onnx/microbenchmark/activation.cc#L342-L344 > Once you've done that,...

> You need sign the license/cla agreement to move on. Yup, working on it.

@yufenglee Couple of questions I need help with: 1) I'm unable to replicate the `Windows CI pipeline` run fail locally (fail log [here](https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1382352&view=logs&j=2c350baf-0cef-5ef1-cbeb-e5cd88c89a11&t=e2851d88-2248-5227-ac0b-d999486a4bf5)). The test `LSTMTest.BackwardCompute` passes for me. Any...

> The 1st failure is with DML EP on. Did you build with dml ep enabled? Nope, let me try building with DirectML. > For the 2nd issue, @snnn ,...