odbc icon indicating copy to clipboard operation
odbc copied to clipboard

Published 20 hours ago • verified publisher icon r-dbi

Add a semicolon to the Teradata sqlCreateTable method

Open edgararuiz-zz opened this issue 6 years ago • 2 comments

It was reported by a user that appending a semi-colon to the end of the ON COMMIT PRESERVE ROWS line fixes an issue he has been getting: https://github.com/tidyverse/dplyr/issues/3531. Specifically, the change needs to be made here: https://github.com/r-dbi/odbc/blob/74ad62c275b1c95a70814707901bdafd8fc2d2b6/R/db.R#L32

PR is forthcoming

edgararuiz-zz avatar May 23 '18 02:05 edgararuiz-zz

Any update on this @edgararuiz? the change is trivial, but IIRC you don't need explicit semicolons at the end of statements in the ODBC API, so it is a bit surprising. It would be great if you could make the change locally and verify it fixes the issue.

jimhester avatar Jun 08 '18 14:06 jimhester

Is the solution to just add a ; to line 32? If I'd happily create a PR.

kieran-mace avatar Aug 22 '18 16:08 kieran-mace