bigrquery icon indicating copy to clipboard operation
bigrquery copied to clipboard

Published 20 hours ago • verified publisher icon r-dbi

dbplyr 2.2.0 compat

Open mgirlich opened this issue 2 years ago • 0 comments

Fixes #495 and fixes #492. Note that you still get the warning about the old interface. It would be great if you could also switch to the 2nd edition. The old interface is deprecated and we plan to remove it next year.

mgirlich avatar Jul 30 '22 08:07 mgirlich

Looking forward to getting this PR approved and merged! Anything I can do to help?

kieran-mace avatar Aug 11 '22 17:08 kieran-mace

@jennybc I saw you are one of the authors of bigrquery. Maybe you want to review and merge this? I think this would make people very happy 😄

mgirlich avatar Aug 12 '22 04:08 mgirlich

Sorry for the late reply. Completely forgot about this... Now this does not rely on purrr anymore and should hopefully work.

mgirlich avatar Aug 30 '22 11:08 mgirlich

Thanks @mgirlich!

jennybc avatar Aug 30 '22 14:08 jennybc

@mgirlich bigrquery is now failing CI on the main branch. In hindsight, even though I approved GHA for this PR, I guess the full live API workflow did not run.

Can you have a look at this failure and make a new PR?

https://github.com/r-dbi/bigrquery/runs/8094638890?check_suite_focus=true#step:9:132

jennybc avatar Aug 30 '22 14:08 jennybc