bigrquery
bigrquery copied to clipboard
r-dbi
Rstudio ui connection
Something is wrong with this PR — it's showing much more in the diff than I'd expect.
Something is wrong with this PR — it's showing much more in the diff than I'd expect.
@byapparov Would you rebase this branch on master and force push this branch? That should make a smaller, cleaner diff.
@hadley I have used this documentation to implement it: https://rstudio.github.io/rstudio-extensions/connections-contract.html
BigQuery objects need to be linked to this contract, which kind of makes sense.
Let me know if you know of a better way.
@jennybc I don't think I see what you see. When I look at changes in GitHub, all seems relevant to this PR.
Hmm, I was just providing instructions from a general point of view. If the diff looks correct and minimal to you, then so be it.
np, I think it will help if you try to select data from BigQuery in Rstudio to see what this is doing.
e.g. you need to run dbConnect() which should bring list all the projects, datasets and tables from your Organisation in Connections panel.
devtools::install_github("byapparov/bigrquery", ref = "rstudio-ui-connection")
con <- dbConnect(bigquery(), project = "your-project-name")
I am also trying to get the snippet for connection work based on this: https://db.rstudio.com/advanced/snippets/ https://rstudio.github.io/rstudio-extensions/rstudio-connections.html#snippet-files
Do you think it would be useful to default project to what is set in env variable, e.g. BIGQUERY_PROJECT ?
Just to say this somewhere @byapparov, there will be another update to bigrquery, at the very least, when I rework its request and response handling to use gargle. We needed to get v1.2.0 out, to get the auth transition rolling, but there will be more chances for your PRs to play out and hopefully be incorporated. We needed to switch the default oauth app, in order to use one from a verified GCP project, with a proper consent screen and privacy policy.
No problems, it is good to see the package moving in all directions.
We can work with the fork for some time.
On the code reviews, I understand you are busy and my expectations are low. It feels like you would benefit from more maintainers to do reviews and approve.
I appreciate all the work that is done here, it's truly amazing )
