RMariaDB icon indicating copy to clipboard operation
RMariaDB copied to clipboard

Swap readr for data.table as creator of TSV

Open jd4ds opened this issue 2 years ago • 4 comments

This closes #270.

jd4ds avatar Jun 14 '22 19:06 jd4ds

Thanks. I tweaked myself to ensure that CI/CD is run.

Should we perhaps consider offering both ways of creating the CSV files, and perhaps make the data.table way opt-in for now?

krlmlr avatar Jun 18 '22 01:06 krlmlr

Something's not quite right yet with the tests, could you please take a look?

krlmlr avatar Jun 18 '22 01:06 krlmlr

Ok I'll see if I understand whats going on.

jd4ds avatar Jun 20 '22 16:06 jd4ds

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] avatar Apr 01 '24 16:04 aviator-app[bot]