DBItest icon indicating copy to clipboard operation
DBItest copied to clipboard

Introduce "strict" mode for `bigint` setting

Open nbenn opened this issue 1 year ago • 1 comments

Commit 641ec8b on branch dev for adbi adds experimental support for "strict" bigint options: "integer-strict" and "numeric-strict" both error on lossy data conversions (due to overflow or rounding).

Using "integer-strict" as default causes issues with tests:

  • [ ] data_64_bit_numeric
  • [ ] data_64_bit_numeric_warning
  • [ ] data_64_bit_lossless
  • [ ] arrow_read_table_arrow

Further issues might exist but currently do not reach the point where this issue comes up. Candidates include

  • [ ] roundtrip_64_bit_numeric
  • [ ] roundtrip_64_bit_character
  • [ ] roundtrip_64_bit_roundtrip

nbenn avatar Dec 18 '23 18:12 nbenn

Thanks for the heads-up, looks good!

We should expand the specs here. It will take some time because I want to inline the checks first. The skips in adbi are fine for now, except I don't see why arrow_read_table_arrow would fail.

krlmlr avatar Dec 18 '23 19:12 krlmlr