topgrade icon indicating copy to clipboard operation
topgrade copied to clipboard

Fix Doom upgrade command

Open reinaldoossuna opened this issue 2 years ago • 4 comments

fix #960

reinaldoossuna avatar Jul 06 '22 12:07 reinaldoossuna

Please also detect early-init.el next to init.el, otherwise it ignores doom - or did you already fix that?

xeruf avatar Jul 07 '22 18:07 xeruf

I don't check for an init.el or early-init.el if the system has doom emacs.

line 82

if let Some(doom) = &self.doom {
    Emacs::update_doom(doom, ctx)
} else {
    let init_file = require_option(self.directory.as_ref(), String::from("Emacs directory does not exist"))?
	....

reinaldoossuna avatar Jul 08 '22 19:07 reinaldoossuna

LET SOME DOOM SELF DOOM

reads kinda funny, anyways, good to know, thank you :)

xeruf avatar Jul 09 '22 21:07 xeruf

Hi @reinaldoossuna - can you please rebase this PR so that we can review and merge it? Also it seems there are still outstanding comments here that need to be addressed

vmalloc avatar Oct 12 '22 06:10 vmalloc