Richard Barnes
Richard Barnes
Summary: `numel()` has type `int64_t`. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Using `auto` ensures that the correct...
Summary: `numel()` has type `int64_t`. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Using `auto` ensures that the correct...
This is super cool! But on the demo I'm seeing the error ``` react-dom.production.min.js:216 TypeError: Cannot read properties of null (reading 'A1') ```
## Details ___Do not mention proprietary info or link to internal work items in this PR.___ **Work item:** _"Internal", or link to GitHub issue (if applicable)._ **What were the changes?**...
Summary: LLVM has a warning `-Wunreachable-code-break` which identifies `break` statements that cannot be reached. These compromise readability, are misleading, and may identify bugs. This diff removes such statements. Such statements...
Summary: LLVM has a warning `-Wunreachable-code-break` which identifies `break` statements that cannot be reached. These compromise readability, are misleading, and may identify bugs. This diff removes such statements. Such statements...
### Which component requires the feature? CUTLASS C++ ### Feature Request As a heads-up, PyTorch is moving to C++20: * https://github.com/pytorch/pytorch/issues/167822 * https://github.com/pytorch/pytorch/pull/167929
`-Wimplicit-fallthrough` is a very high signal warning. In internal testing we found that 30-40% of flagged instances were bugs of some sort. CUTLASS currently passes `-Wimplicit-fallthrough`, but doesn't enforce it....
Summary: This diff enables compilation warning flags for the directory in question. Further details are in [this workplace post](https://fb.workplace.com/permalink.php?story_fbid=pfbid02XaWNiCVk69r1ghfvDVpujB8Hr9Y61uDvNakxiZFa2jwiPHscVdEQwCBHrmWZSyMRl&id=100051201402394). This is a low-risk diff. There are **no run-time effects** and...
clang's `-Wunused-value` discovered that this line https://github.com/cvangysel/pytrec_eval/blob/0d8571efc2dea5a792358410d5affbe0ad383602/src/pytrec_eval.cpp#L819 doesn't do anything. Can it be removed or should something here be fixed?