qxmpp icon indicating copy to clipboard operation
qxmpp copied to clipboard

Add convenience data retrieval method to QXmppBitsOfBinaryDataList

Open jbruechert opened this issue 2 years ago • 2 comments

PR check list:

  • [x] Document your code
  • [x] Add \since QXmpp 1.X, QXMPP_EXPORT
  • [x] Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
  • [x] Update doc/doap.xml
  • [ ] Add unit tests
  • [ ] Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

jbruechert avatar Sep 27 '22 21:09 jbruechert

Codecov Report

Base: 68.60% // Head: 68.24% // Decreases project coverage by -0.36% :warning:

Coverage data is based on head (e62c02d) compared to base (f762f73). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   68.60%   68.24%   -0.37%     
==========================================
  Files         283      293      +10     
  Lines       24571    25108     +537     
==========================================
+ Hits        16857    17134     +277     
- Misses       7714     7974     +260     
Impacted Files Coverage Δ
src/base/QXmppBitsOfBinaryData.cpp 90.90% <0.00%> (-9.10%) :arrow_down:
src/base/QXmppBitsOfBinaryDataList.h 100.00% <ø> (ø)
src/base/QXmppFileShare.cpp 45.33% <0.00%> (-16.94%) :arrow_down:
src/base/QXmppUtils.cpp 81.98% <0.00%> (-4.69%) :arrow_down:
src/base/QXmppFileMetadata.cpp 50.87% <0.00%> (-1.51%) :arrow_down:
src/client/QXmppFileEncryption.cpp 67.44% <0.00%> (-1.07%) :arrow_down:
src/base/QXmppMessage.cpp 98.31% <0.00%> (-0.55%) :arrow_down:
tests/qxmppmessage/tst_qxmppmessage.cpp 94.82% <0.00%> (-0.02%) :arrow_down:
src/base/QXmppError.h 0.00% <0.00%> (ø)
src/base/QXmppError.cpp 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 27 '22 21:09 codecov[bot]

@jbb There is a typo: It should be convenience :)

melvo avatar Sep 29 '22 18:09 melvo