qxmpp
qxmpp copied to clipboard
Skip all integration tests if disabled
PR check list:
- [x] Document your code
- [x] Add
\since QXmpp 1.X
- [x] Fix doxygen warnings (see log when building with
-DBUILD_DOCUMENTATION=ON
) - [x] Update
doc/xep.doc
- [x] Add unit tests
- [x] Format the code: Run
clang-format -i src/<edited-file(s)> tests/<edited-file(s)>
That's no integration test. I know that these tests can cause problems, but marking them as "integration tests" is questionable.
Codecov Report
Merging #439 (71bb717) into master (e577f28) will decrease coverage by
3.64%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 69.29% 65.64% -3.65%
==========================================
Files 252 252
Lines 23289 23354 +65
==========================================
- Hits 16138 15331 -807
- Misses 7151 8023 +872
Impacted Files | Coverage Δ | |
---|---|---|
...ests/qxmppiceconnection/tst_qxmppiceconnection.cpp | 4.65% <ø> (-95.35%) |
:arrow_down: |
tests/qxmppomemomanager/tst_qxmppomemomanager.cpp | 24.54% <ø> (ø) |
|
.../qxmpptransfermanager/tst_qxmpptransfermanager.cpp | 20.87% <ø> (-79.13%) |
:arrow_down: |
tests/qxmppvcardmanager/tst_qxmppvcardmanager.cpp | 52.38% <ø> (ø) |
|
src/base/QXmppIbbIq.cpp | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
src/base/QXmppByteStreamIq.cpp | 0.00% <0.00%> (-84.15%) |
:arrow_down: |
src/client/QXmppTransferManager.cpp | 4.49% <0.00%> (-64.47%) |
:arrow_down: |
src/base/QXmppStreamInitiationIq.cpp | 58.82% <0.00%> (-37.26%) |
:arrow_down: |
... and 4 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
That's no integration test. I know that these tests can cause problems, but marking them as "integration tests" is questionable.
Thanks. How could that problem be solved?
Thanks. How could that problem be solved?
Fixing the tests, marking tests requiring a working internet connection as online tests, make online tests optional.