qxmpp icon indicating copy to clipboard operation
qxmpp copied to clipboard

get resume id from server

Open coderlxn opened this issue 7 years ago • 7 comments

coderlxn avatar Nov 30 '17 10:11 coderlxn

LGTM.

olesalscheider avatar Jun 23 '18 14:06 olesalscheider

IQ parsing / serialization is trivial to unit test, so do it :)

jlaine avatar Jun 23 '18 15:06 jlaine

@coderlxn can we please have a unit test for this so we can merge it?

jlaine avatar Sep 30 '18 09:09 jlaine

@lnjX I'm not sure I understand what this does anymore, ideas?

jlaine avatar Jan 21 '19 08:01 jlaine

@jlaine The session id needs to be parsed to be able to resume the session (using previd in <resume/>) after a possible connection loss.


See https://xmpp.org/extensions/xep-0198.html#resumption

lnjX avatar Jan 21 '19 13:01 lnjX

@jlaine What kind of unit test should I add for this pull request? Sorry, I'm not familiar with the progress of pull request.

coderlxn avatar Jan 27 '19 05:01 coderlxn

Unfortunately there's no test class for stream management, yet, but you could base on this test basically. It were also nice to have this new test class in a new commit.

lnjX avatar Jan 27 '19 21:01 lnjX