ch_vd_sire extension in main data-model @ 0265787 is less complete that the one in the extensions_sire repository

[nicolas-sitylb]

Hello,

Would it make sense to update the data-model @ 0265787/extensions/ch_vd_sire in the main 'qwat/qwat' repository to fit the one found in the qwat/extension_sire ?

Indeed, the latter seems more complete.

Or is there any reason to keep it separate?

[haubourg]

@nicolas-sitylb Hi, the url you mention points to a commit back into the history of QWAT when the SIRE extension was part of the core. If you look at the master branch, it as been removed from the core, so that the only reference is extension_sire. It was decided to remove all the extensions out of the core to allow them to have their own lifecycle.

[nicolas-sitylb]

Thanks for the reply.

I understand, but when I clone the main QWAT repository from here: https://github.com/qwat/QWAT and then, when I update the submodules according to the main documentation using git submodule update --init --recursive, the data_model/extensions/ch_vd_sire folder is loaded.
And it seems to be the one from the above-mentioned old commit (0265787)...

[ponceta]

@nicolas-sitylb Thanks for your feedback, it seems that there is maybe something missing or to be fixed in the from scratch installation steps!

[ponceta]

@lbartoletti peux-tu dans le cadre de la release 1.3.5 vérifier que l'extension SIRE est bien celle de la dernière version?

[lbartoletti]

@ponceta qwat/QWAT a un datamodel qui est encore à la version 1.3.3 (d'où un reste de SIRE). En 1.3.4 il n'y a plus de SIRE. Donc, pour la release 1.3.5 je mettrai à jour le submodule dans qwat/QWAT pour pointer vers la dernière version de qwat-data-model