qwat-data-model icon indicating copy to clipboard operation
qwat-data-model copied to clipboard

chamber enhancements

Open tudorbarascu opened this issue 8 years ago • 1 comments

Hello,

we also have a need to save the chamber material attribute. Does anyone else has this need or it's particular to our use case?

Also, by looking at the chamber table, there are some columns with booleans that may be better as smallint so that they could also present the no of objects.

            Table "qwat_od.chamber"
      Column       |     Type      | Modifiers 
-------------------+---------------+-----------
 id                | integer       | not null
 networkseparation | boolean       | 
 flow_meter        | boolean       | 
 water_meter       | boolean       | 
 manometer         | boolean       | 
 depth             | numeric(10,3) | 
 no_valves         | smallint      | 

For instance, alike no_valves, the water_meter column which is now a boolean cold be changed to an smallint column named no_water_meter so that it presents the number of water meters in that chamber.

Thoughts?

tudorbarascu avatar Dec 26 '16 13:12 tudorbarascu

Revisiting this, IMHO it makes sense to enhance the data model and turn flow_meter to no_flow_meters (from boolean to smallint), same for water_meter so that we can also hold the exact number of specific elements in that chamber.

tudorbarascu avatar Nov 20 '18 07:11 tudorbarascu