QWAT icon indicating copy to clipboard operation
QWAT copied to clipboard

Snapping an hydrant on a pipe en vertex does not merge nodes

Open haubourg opened this issue 8 years ago • 10 comments

When creating an hydrant snapped on pipe extremity, the underlying node is reused to inherit the hydrant. When just snapping an existing hydrant to a pipe end, we still have two nodes, and no way to select by attribute query the hydrante- pipe relations. @3nids is this made on purpose or a design issue?

haubourg avatar Feb 21 '17 14:02 haubourg

it's an issue, on a node inherited class move, there should be a new node creation process (if an exisiting one is found, it should be reused). This is an easy test case by the way.

3nids avatar Feb 21 '17 15:02 3nids

Planning that to mid 2017 and raising priority

haubourg avatar Apr 28 '17 14:04 haubourg

combining qwat_od.ft_element_hydrant_delete() and qwat_od.ft_element_hydrant_insert() into qwat_od.ft_element_hydrant_update() do the job.

@3nids is this trigger generated by metaproject? How to change it? Thanks.

lbartoletti avatar Apr 11 '18 09:04 lbartoletti

ping @3nids

lbartoletti avatar Apr 18 '18 10:04 lbartoletti

Denis @3nids ?

lbartoletti avatar Jun 04 '18 09:06 lbartoletti

Status of this? If it's an issue it should be corrected (before 1.3.3?)

ponceta avatar Oct 30 '18 15:10 ponceta

@lbartoletti yes the triggers are generated automatically (metaproject) But this should not happen at the hydrant but at the network or node level.

3nids avatar Oct 30 '18 15:10 3nids

@lbartoletti can you push a fix now ?

haubourg avatar Nov 05 '18 11:11 haubourg

OK, after testing, all installations are also afected. We probably need a gobal business rule to merge nodes when we want to snap to an existing node and merge underlying nodes. This is a big refactoring step, so I postpone the milestone in order to let the 1.3.3 release fly this week.

haubourg avatar Nov 13 '18 14:11 haubourg

@haubourg IMHO it should be considered a bug (very high priority even).

tudorbarascu avatar Nov 15 '18 12:11 tudorbarascu