Git commits don't work in :terminal buffers when using "vimr --wait" as EDITOR

[jparoz]

I'm using VimR on an Intel MacBook Air, with fish as my shell. When I open :terminal in VimR, I can use most functions of the terminal correctly. Particularly, when using "vimr --wait" from within the VimR terminal buffer, I can do stuff in the new window that opens, close the window, and the process correctly exits.

However, when I have EDITOR="vimr --wait", and I try to do git commit, it launches my EDITOR; when I save and close the newly opened VimR buffer with the commit message, the terminal buffer from which I launched the git commit stays stuck with the message "hint: Waiting for your editor to close the file..." I can use a CTRL-C to stop the buffer from waiting, but it cancels the commit.

Steps to reproduce (from inside a :terminal buffer):

mkdir test; cd test
git init
touch foo.txt
git add -A

# This will never return:
env EDITOR="vimr --wait" git commit

# This works as expected:
env EDITOR=nano git commit