vimr icon indicating copy to clipboard operation
vimr copied to clipboard

Published 20 hours ago • verified publisher icon qvacua

Modify theming code: custom tab theme is now pulled from TablineSel highlight group

Open s-daveb opened this issue 9 months ago • 1 comments

Fixes the issue raised in #1058 where the everforest theme results in low-contrast tabs, by using color groups that were meant for tabs

Before Screenshot 2024-05-06 at 2 58 17 PM

After Screenshot 2024-05-06 at 2 57 50 PM

s-daveb avatar May 06 '24 19:05 s-daveb

Thank you a log for the PR! However, I noticed that with darker theme, the close button is not visible in the active tab; could you have a look? I'm using https://github.com/dracula/vim . Screenshot 2024-05-12 at 13 44 51

qvacua avatar May 12 '24 11:05 qvacua

Screenshot 2024-05-15 at 2 12 34 PM

How is this? I tested it with Dracula, and it looks okay.

s-daveb avatar May 15 '24 18:05 s-daveb

There are still pending problems with themes such as 'Ron' and other dark themes... I'll see if I can find an easy solution

s-daveb avatar May 15 '24 18:05 s-daveb

Screenshot 2024-05-15 at 10 53 02 PM

Latest code changes have it rendering like this for me, under the 'ron' theme. Does this work for you?

s-daveb avatar May 16 '24 02:05 s-daveb

LGTM!

qvacua avatar May 17 '24 06:05 qvacua