Nick

Results 172 comments of Nick

> Obviously, configuring on a per-fleet basis in the system definition would be nice, Yes that's definitely better. I don't think it makes much sense to have this be a...

So to be clear, this > ships will linger 1/4 of the minimum fleet arrival period of the system is too high for certain systems?

Having it be configurable per fleet makes sense to me yeah. But making it configurable by system doesn't really, and I think I just don't get your explanations. > If...

> but it ignores one important type of ship: NPC ships For this you could add a node for NPCs that would override the linger time, similar to how it's...

Yes sorry I meant the `shared_ptr` id. > to connect the id to missions. connect the fleet id to missions?

TBH I'm not a fan of moving the mouse like that, it seems hacky. I think we should either: 1) Accept this bug as "working as intended" since it allows...

~~yeah I know it's intended but I don't like it~~ Seems good, I've tested it on Windows and it works fine there too. Just need someone to test this on...

I feel like this PR can be simplified a bit; more specifically, it feels like you don't need `govAttraction` at all and can instead do a combination of - Instead...

> My solution doesn't use string comparisons - it uses simple enum (int) comparison-based logarithmic time lookups (for Attributes), which is way faster. I didn't realize it doesn't go through...

> because there is no way I'm writing a separate class for each action (category) and effect The idea is that each action attribute can be a variable of the...