Nick

Results 154 comments of Nick

> What public functions are you referring to? @shitwolfymakes all the ones that are added. At least to me, it makes reading and understanding the code much more complex.

> If you mean that the previous implementation of Step() was less complex, that is not the case. The old implementation was 142 lines long, with a cognitive complexity of...

Take Step for example. Sure it's a long function, but that's because it's doing a lot of stuff. But I can go through it and it's fairly understandable. With your...

> Could someone (@quyykk) please tell me how to add libgit2 to vcpkg? I have no idea how that works. You can add it to vcpkg.json, where the other libraries...

Yeah, there's also: - Declaring variables at the top of the function - Using `struct` when defining variables - All those printf calls (it's probably not even necessary to print...

@xX-Dillinger-Xx > it sounds like your suggesting we don't need PR#9844 yes > I'm I too assume you think having to reload a save file is a good enough solution?...

![image](https://user-images.githubusercontent.com/85879619/204155842-1c691541-202c-4d9d-9063-eeebc64cf65d.png) oops

> Honestly, that sounds like overcomplicating it compared to just using the events I mean maybe? But it would just involve adding a single if check vs looping through every...

Would prioritizing non-drones when pressing Board be a possible solution? No idea if this is a good idea though.

Let's not do backwards time travel for now, we can always add it back later if necessary.