sqlhooks icon indicating copy to clipboard operation
sqlhooks copied to clipboard

[Discussion] onError hook error ignore

Open fatelei opened this issue 3 years ago • 4 comments

i add onError hook, add collect driver.ErrSkip error, how about add error check before call onError

fatelei avatar Aug 19 '22 10:08 fatelei

you mean that onErorr hook is being called with a driver.ErrSkip error?

qustavo avatar Aug 21 '22 11:08 qustavo

yes, so i want to submit a pr to ignore this error

fatelei avatar Aug 21 '22 11:08 fatelei

although sounds reasonable, it will break the API. Please go ahead and create the PR, and let other ppl review it.

qustavo avatar Aug 21 '22 12:08 qustavo

ok

fatelei avatar Aug 21 '22 14:08 fatelei