react-bootstrap-datetimepicker icon indicating copy to clipboard operation
react-bootstrap-datetimepicker copied to clipboard

Published 20 hours ago • verified publisher icon quri

Fix/react 16 update

Open brewsoftware opened this issue 7 years ago • 3 comments

This relates to a split in the latest React framework. In React > 15.5 the "PropTypes" library has been broken out of the core framework. In the latest react version 16.0 this means that PropTypes needs to be explicitly imported.

15.5 import React from 'react'

React.PropTypes.func.isRequired

16.0 import React from 'react' import PropTypes from 'prop-types'

PropTypes.func.isRequired

brewsoftware avatar Nov 01 '17 21:11 brewsoftware

Someone going to merge this PR?

elhay-av avatar Feb 04 '18 16:02 elhay-av

no, there is a pretty big notice on the front page in case you missed it: https://github.com/quri/react-bootstrap-datetimepicker#%EF%B8%8F-deprecated-react-bootstrap-datetimepicker

chollier avatar Feb 04 '18 18:02 chollier

It wouldn't be a bad idea to re-publish the package with the deprecation notice, the NPM page doesn't hint at it being deprecated and 27K downloads/month suggest people really are missing the message.

guioconnor avatar Mar 08 '18 15:03 guioconnor