react-bootstrap-datetimepicker icon indicating copy to clipboard operation
react-bootstrap-datetimepicker copied to clipboard

Published 20 hours ago • verified publisher icon quri

Markup cleanup

Open unthunk opened this issue 9 years ago • 3 comments

Since this is a port of a jQuery plugin, updated markup in plugin to more closely match. Replaced the custom CSS for this plugin with the CSS from the jQuery plugin and added the origin plugin as a dependency. Also fixed/removed positioning CSS in plugin (no changes to positioning logic). These changes should be useful for anyone porting from the jQuery plugin to React or supporting both versions.

unthunk avatar Oct 26 '15 18:10 unthunk

Thanks @unthunk for your contribution. I don't think there was anything custom in the CSS, I simply copied it from the plugin, however it is possible I did this for the version 3 of the plugin not 4.

Is there a specific reason you removed the minified version ?

chollier avatar Oct 26 '15 21:10 chollier

Hi @chollier,

If you are referring to the minified stylesheet is should still be there, just with the current version from eonasdan-bootstrap-datetimepicker. If it's a different file you are referring to let me, I didn't intentionally remove/omit any files and can make an update if needed.

unthunk avatar Oct 26 '15 21:10 unthunk

Just added fixes for the broken tests.

unthunk avatar Oct 28 '15 21:10 unthunk