quran.com-frontend icon indicating copy to clipboard operation
quran.com-frontend copied to clipboard

Published 20 hours ago • verified publisher icon quran

Fixing the audio delay at #996

Open bahaa96 opened this issue 6 years ago • 18 comments

Title of change

Fixing the audio delay at #996

Checklist

  • [ ] Unit tests written
  • [ ] Manually tested
  • [ ] Prettier & ESLint were run
  • [ ] New dependencies are included in package-lock.json

Screenshot

I think a screenshot of the logs wouldnt be helpful.

bahaa96 avatar Jul 20 '18 15:07 bahaa96

Deployed to: http://staging.quran.com:32842

ahmedre avatar Jul 20 '18 15:07 ahmedre

Deployed to: http://staging.quran.com:32845

ahmedre avatar Jul 20 '18 21:07 ahmedre

A Video for the second commit: https://youtu.be/j8YE-bpUJ1A

bahaa96 avatar Jul 20 '18 21:07 bahaa96

Deployed to: http://staging.quran.com:32846

ahmedre avatar Jul 21 '18 14:07 ahmedre

This is a video describing the third commit: https://youtu.be/CbcT6J_yBeM

bahaa96 avatar Jul 21 '18 14:07 bahaa96

@bahaa96 can you check your console error please? https://youtu.be/Iy2WT7eAjqw

Mac, Chrome. Can't click on Repeat option.

naveed-ahmad avatar Jul 21 '18 14:07 naveed-ahmad

Deployed to: http://staging.quran.com:32847

ahmedre avatar Jul 21 '18 14:07 ahmedre

Deployed to: http://staging.quran.com:32848

ahmedre avatar Jul 21 '18 18:07 ahmedre

Deployed to: http://staging.quran.com:32849

ahmedre avatar Jul 21 '18 21:07 ahmedre

Deployed to: http://staging.quran.com:32850

ahmedre avatar Jul 22 '18 22:07 ahmedre

Deployed to: http://staging.quran.com:32851

ahmedre avatar Jul 24 '18 19:07 ahmedre

rebuild

naveed-ahmad avatar Jul 26 '18 19:07 naveed-ahmad

rebuild

bahaa96 avatar Jul 26 '18 21:07 bahaa96

@bahaa96 thanks a ton for this! Mind if we hold on till this: https://github.com/quran/quran.com-frontend/pull/1005

mmahalwy avatar Jul 27 '18 02:07 mmahalwy

TYT, It's working well on localhost and I can work on more features till u done with that. <3

bahaa96 avatar Jul 27 '18 07:07 bahaa96

@bahaa96 I'd suggesting holding. Need a few more days. That PR is a rewrite of many of the features, including the way we traditionally have done audio. I think it's much needed since our audioplayer is always broken

mmahalwy avatar Jul 27 '18 17:07 mmahalwy

@bahaa96 close this?

naveed-ahmad avatar Jan 31 '19 09:01 naveed-ahmad

Deployed to: http://staging.quran.com:32820

ahmedre avatar Jan 31 '19 09:01 ahmedre