quran.com-frontend icon indicating copy to clipboard operation
quran.com-frontend copied to clipboard

Published 20 hours ago • verified publisher icon quran

Convert Smartbanner to styled-components

Open mmahalwy opened this issue 6 years ago • 10 comments

I'm submitting a ...

  • [ ] bug report
  • [ ] feature request
  • [x] other

Current behavior: The Smartbanner component is heavily using CSS and should instead use styled-components

Expected / new behavior: Convert to styled-components please!

mmahalwy avatar Aug 29 '18 20:08 mmahalwy

I can take this.

atalebagha avatar Aug 30 '18 00:08 atalebagha

@atalebagha please do! I will merge this soon: https://github.com/quran/quran.com-frontend/pull/1005

Then can open it up for everyone to help out. Still a few missing items that I need to do after I merge it inshallah

mmahalwy avatar Aug 30 '18 09:08 mmahalwy

Is this still open ?

bahaa96 avatar Sep 13 '18 17:09 bahaa96

@bahaa96 Yep!

mmahalwy avatar Sep 14 '18 05:09 mmahalwy

The SmartBanner file is over 500 lines now do you prefer to move the styled components to a separate file ?

bahaa96 avatar Sep 14 '18 15:09 bahaa96

Yes! Separation is always preferable :)

mmahalwy avatar Sep 14 '18 22:09 mmahalwy

@mmahalwy Is this still open? If yes then can I pick it?

atiqueansari1987 avatar Feb 13 '19 11:02 atiqueansari1987

@mmahalwy Can you guide me what changes are needed?

atiqueansari1987 avatar Apr 24 '19 13:04 atiqueansari1987

@bahaa96 did you finish working on this?

fatmali avatar Jul 28 '19 06:07 fatmali

@mmahalwy Just wondering this issue is still open?

kaiyum2012 avatar May 19 '21 01:05 kaiyum2012