Swap Dark and Light Mode Buttons

[rmfaheem]

Issue

It seems that the buttons for the night and day themes do the reverse of what they should do.

Illustration

Day mode:

Night mode:

Minor issue but it should be reversed.

[Yuniac]

Assalamualaikum

I agree with you that it is a little bit inconvenient because the color is a little bit too transparent, does this look better to you?

Dark mode:

Light mode:

Or you meant that the currently active mode icon shouldn't have a modifier color but the inactive mode icon should have it? I think the idea here is the currently active mode has that greenish color to stand out and signals that it is the current active one.

[rmfaheem]

I think the idea here is the currently active mode has that greenish color to stand out and signals that it is the current active one.

I agree that this is what we should be going for. But it does not seem to be case currently...?

Currently: When dark mode is enabled, the light bulb is purple. When light mode is enabled, the moon icon is purple.

Should it not be: When dark mode is enabled, the moon icon is purple. When light mode is enabled, the light bulb is purple.

[Yuniac]

I think not. I think as it is now is correct because when "When dark mode is enabled, the light bulb is purple." signals to the user that: "Hey, I'm a light pulp and I'm clickable" and the user tries and click so it swaps themes. And Allah knows best.

[Yuniac]

Assalamualaikum

I agree with you that it is a little bit inconvenient because the color is a little bit too transparent, does this look better to you?

Dark mode:

Light mode:

Or you meant that the currently active mode icon shouldn't have a modifier color but the inactive mode icon should have it? I think the idea here is the currently active mode has that greenish color to stand out and signals that it is the current active one.

I can purpose this change in a PR too, btw. I personally think it fits better and more clear.

[Taimoorkhan1122]

Assalamualaikum I agree with you that it is a little bit inconvenient because the color is a little bit too transparent, does this look better to you? Dark mode: Light mode: Or you meant that the currently active mode icon shouldn't have a modifier color but the inactive mode icon should have it? I think the idea here is the currently active mode has that greenish color to stand out and signals that it is the current active one.

I can purpose this change in a PR too, btw. I personally think it fits better and more clear.

Assalam o alikum, I also noted this issues, its really confusing in terms of UX, I clicked light bulb for switching to light mode but it is disabled and currently highlighted 😕 if it's done intentionally (the highlight color) so, why the button which in not currently selected is disabled? It should toggle to light mode when I click the "light buld".

[Yuniac]

Assalamualaikum I agree with you that it is a little bit inconvenient because the color is a little bit too transparent, does this look better to you? Dark mode: Light mode: Or you meant that the currently active mode icon shouldn't have a modifier color but the inactive mode icon should have it? I think the idea here is the currently active mode has that greenish color to stand out and signals that it is the current active one.

I can purpose this change in a PR too, btw. I personally think it fits better and more clear.

Assalam o alikum, I also noted this issues, its really confusing in terms of UX, I clicked light bulb for switching to light mode but it is disabled and currently highlighted 😕 if it's done intentionally (the highlight color) so, why the button which in not currently selected is disabled? It should toggle to light mode when I click the "light buld".

I think I understand the issue better now and I agree with you and the OP, it is indeed confusing and inconvenient... it is so confusing that I was trying to make a case for it even and defend it.