qupath icon indicating copy to clipboard operation
qupath copied to clipboard

Improve dialog that appears on startup

Open petebankhead opened this issue 3 years ago • 2 comments

Bug report

Describe the bug When QuPath is first launched, a few key options are presented to the user - which are currently the memory settings, locale and whether to check for updates.

Except that these are no longer really key.

The memory setting was important in early releases, when memory was specified in absolute terms (e.g. 4GB). Most users would want to increase it depending upon what is available. However, now memory defaults to 50% of the available system memory, which means it's less likely to require adjustment.

What's more, the memory can't even be adjusted on macOS anyway due to permissions limitations.

Changing the locale is also strongly discouraged, since it can cause confusion - especially when inputting numbers (using a comma or decimal separator).

Therefore space is give to a dialog that is no longer fully functional on all platforms, and isn't really needed.

To Reproduce Check the current display via Help → Show setup options.

Expected behavior Three main things:

  • Show a more informative and useful startup dialog, e.g. to introduce the user interface, forum or documentation.
  • Relegate non-essential options to the preferences.
  • Retain a checkbox to specify whether to check for updates or not

Screenshots

Current dialog, as it appears on a Mac. Screenshot 2022-06-02 at 09 37 51

Desktop (please complete the following information):

  • OS: All
  • QuPath v0.3.2

Additional context The locale settings have already been moved to the preferences in https://github.com/qupath/qupath/pull/971 This issue really exists to track the progress of the other required changes for v0.4.0.

petebankhead avatar Jun 02 '22 08:06 petebankhead

However, now memory defaults to 50% of the available system memory

I would understand that this works for computers with not much RAM (e.g. 8 GB or 16 GB). But when you have 64 GB RAM or more, will using only 50% of available system memory mean having the other half of the massive RAM essentially unused?

yau-lim avatar Jun 30 '22 21:06 yau-lim

It will still be possible to change the RAM, it just wouldn't be such a prominent option on startup.

I'm not sure what the best default is, but I have the impression that more users will have too little RAM than too much - and the proportion needs to be defined when QuPath is built (I don't know any way to change it after it is installed).

petebankhead avatar Jul 01 '22 04:07 petebankhead

Fixed by

  • https://github.com/qupath/qupath/pull/1124
  • https://github.com/qupath/qupath/pull/1125

Extra comment on the memory: the limit affects Java, but JavaCPP can potentially access more memory. Therefore the most memory-hungry thing (pixel classification) isn't strictly subject to the same limit.

It should still be possible to specify the memory in the preferences on Windows/Linux, but this needs checked.

petebankhead avatar Nov 09 '22 08:11 petebankhead