quokka icon indicating copy to clipboard operation
quokka copied to clipboard

random blast ISM problem

Open BenWibking opened this issue 2 years ago • 4 comments

This simulates the explosion of supernovae in a homogeneous ISM.

BenWibking avatar Nov 11 '22 22:11 BenWibking

This pull request introduces 1 alert when merging f819e72d27767c15d78ab9bde07692804503523e into 19a890e302322d95873e979590303f408d4e3c0e - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Nov 12 '22 20:11 lgtm-com[bot]

~~TODO: add compile-time option to use HLL solver.~~

BenWibking avatar Nov 14 '22 03:11 BenWibking

Why is this PR still open as it was approved a year ago?

chongchonghe avatar Dec 10 '23 02:12 chongchonghe

Why is this PR still open as it was approved a year ago?

I think what happened was there were immediately merge conflicts from another PR, and then I never got around to fixing those. It will have to be re-approved once those are fixed anyway.

BenWibking avatar Dec 10 '23 17:12 BenWibking

/azp run

BenWibking avatar Jul 09 '24 00:07 BenWibking

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '24 00:07 azure-pipelines[bot]

/azp run

BenWibking avatar Jul 09 '24 18:07 BenWibking

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '24 18:07 azure-pipelines[bot]

/azp run

BenWibking avatar Jul 09 '24 22:07 BenWibking

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '24 22:07 azure-pipelines[bot]

/azp run

BenWibking avatar Jul 10 '24 02:07 BenWibking

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 10 '24 02:07 azure-pipelines[bot]

@markkrumholz This PR should finally be ready to merge again.

BenWibking avatar Jul 10 '24 03:07 BenWibking