cactbot lint: Handle nullable empty string checks in Raidboss

lint: Handle nullable empty string checks in Raidboss

Open valarnin opened this issue 2 years ago • 2 comments

This is being split off from #4523

Jun 25 '22 20:06 valarnin

The failing test is because of the following lines in the a7s timeline:

https://github.com/quisquous/cactbot/blob/a081e237cda8de6ab112d15c98073af9975edade/ui/raidboss/data/03-hw/raid/a7s.txt#L87-L96

I guess the question is, should they be counted as an error?

Additionally these lines, including the first one since it has a blank name, will also cause the test to fail.

https://github.com/quisquous/cactbot/blob/a081e237cda8de6ab112d15c98073af9975edade/ui/raidboss/data/03-hw/raid/a7s.txt#L172-L181

Jun 25 '22 21:06 valarnin

I guess the question is, should they be counted as an error?

I don't think this is an error.

Jun 27 '22 03:06 quisquous