sammy icon indicating copy to clipboard operation
sammy copied to clipboard

Location history updated prior to before callbacks running

Open ghost opened this issue 13 years ago • 1 comments

The new changes on the non-hash branch (or did your email to the list mean these are now on master?) that support pushState and hash for the relevant browsers updates the browsers location prior to before callbacks being executed. If a before callback then explicitly returns false and prevents the route from being run, the application state falls out of sync with the browser location.

Will try submit a patch over the weekend.

ghost avatar Mar 25 '11 09:03 ghost

I'm also interested in this question, but since it hasn't been answer in 6 years I have no much hope. We're facing some issues with SEO because our implementation using sammy.js is not url friendly for search engines (we use hash character in url #) I have seen there is a branch non-hash and I'd like to find more info on whether it has been merged with master or whether sammy currently supports friendly urls without #.

iberodev avatar May 25 '17 10:05 iberodev