Jacob Quinn

Results 513 comments of Jacob Quinn

So one thing we should consider is whether we should do a breaking change to `CSV.Chunks` (where iteration returns `CSV.Chunk` instead of current `CSV.File`, and required extra materialization call). Or...

@nhdaly, sorry for the slightly random ping, but I'm actually diving back in to the code here and want to make a push. would you mind taking a look here...

Hmmmm.....I don't think that should be possible because we do extra work to ensure chunks only get split _exactly_ on the newline character, so `\n` should _always_ end a chunk...

I'd be curious to know the values [here](https://github.com/JuliaData/CSV.jl/blob/60736525b243c8d02fd54897ca1714d7e10d4043/src/detection.jl#L413) and why that check failed, especially on the full file where it seems like we should have enough columns to get a...

I can't seem to find where it was suggested to limit the types allowed in CategoricalArrays.jl, but that seems to me the best compromise to move forward. It seems with...

Sorry for not being able to review earlier; I think this is exciting stuff! One comment I'll make is that a lot of the current code organization was done in...

The bigger issue here is that for the Parsers.jl package, if you pass in a `Char` delim, it checks if it's ascii and if so, converts it to a `UInt8`....

Yeah, I like the idea of doing more "prettier" things in our normalization pass for now; we could special case characters like `(` and just remove them. We also have...

Just a clarification that the ~100K characters is _per cell_, not per row. I think we can support double the current length without too much trouble; we just need to...