crypto: expose negotiated_cipher_suite in the hadshake data

[BiagioFesta]

As title.

I am not totally convinced by that .expect("cipher is negotiated").

It makes sense to me: as AFAIK reaching that point always implies the cipher is negotiated, but I might have missed a edge scenario

[djc]

I am not totally convinced by that .expect("cipher is negotiated").

It makes to me, as AFIK reaching that point always implies the cipher is negotiated, but I might have missed a edge scenario

Once got_handshake_data is set to true, the inner TLS session is !is_handshaking() so this should be fine.

[Ralith]

Note this is technically a breaking change, since HandshakeData is exhaustive. Shouldn't be disruptive, though.

[BiagioFesta]

I see this change has been reverted because of breaking change I guess.

Is this something we want to re-open?

[Ralith]

Yeah, absolutely. We're happy to have it, just need to defer it to the next breaking release.

[djc]

IIRC it was relanded under an internal feature flag. Would be useful to open a PR that makes it unconditional again, but it might be a while before we merge it.

[Ralith]

I don't think we flagged it.