cbor4ii icon indicating copy to clipboard operation
cbor4ii copied to clipboard

Collaborate with ciborium

Open npmccallum opened this issue 2 years ago • 6 comments

https://github.com/enarx/ciborium/

Can we collaborate rather than building multiple CBOR stacks?

npmccallum avatar Dec 16 '21 13:12 npmccallum

Of course, how do you hope to collaborate?

quininer avatar Dec 16 '21 14:12 quininer

No idea. But I'd rather have one really good CBOR stack than multiple incomplete ones.

Was there some defect or design considerations in ciborium that lead to an alternate implementation?

npmccallum avatar Dec 16 '21 14:12 npmccallum

There are two missing things in ciborium that prompted me to develop this crate

  1. ciborium has not exposed the Serializer api for a long time
  2. ciborium does not support zero-copy decode.

quininer avatar Dec 16 '21 14:12 quininer

There are two missing things in ciborium that prompted me to develop this crate

  1. ciborium has not exposed the Serializer api for a long time

https://github.com/enarx/ciborium/issues/18

We have expressly supported exposing these. But nobody has stepped up to finish it. Would you like to?

  1. ciborium does not support zero-copy decode.

We'd love to have this feature. Although one should note that not all CBOR wire values can be zero-copy decoded.

Would you be willing to contribute these features to ciborium?

npmccallum avatar Dec 16 '21 14:12 npmccallum

I'm not sure how easy this is. when I tried to make ciborium support zero copy decode, I realized that it needed to be changed quite a bit. considering communication costs, I choose to implement my own library.

quininer avatar Dec 16 '21 15:12 quininer

@quininer If this is the biggest blocker, I'm happy to help you implement it.

npmccallum avatar Dec 16 '21 15:12 npmccallum