quilt icon indicating copy to clipboard operation
quilt copied to clipboard

JSON Display improvements

Open fiskus opened this issue 1 year ago • 2 comments

  • Highlight clickable areas on hover
  • Make empty space non-clickable: it's not obvious what should happen on click
  • Move closing braces vertically aligned with opening braces

Clickable areas before: Screenshot from 2023-09-25 13-52-29

Clickable areas after: Screenshot from 2023-09-25 13-46-46

On hover: https://github.com/quiltdata/quilt/assets/533229/83fda124-5cbc-4654-b941-14418e74f542

  • [x] Changelog entry (skip if change is not significant to end users, e.g. docs only)

fiskus avatar Sep 25 '23 10:09 fiskus

Codecov Report

Merging #3734 (b471445) into master (e10ecb4) will increase coverage by 54.34%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3734       +/-   ##
===========================================
+ Coverage   34.82%   89.16%   +54.34%     
===========================================
  Files         709       79      -630     
  Lines       31105     9942    -21163     
  Branches     4638        0     -4638     
===========================================
- Hits        10831     8865     -1966     
+ Misses      19125     1077    -18048     
+ Partials     1149        0     -1149     
Flag Coverage Δ
api-python 91.23% <ø> (-0.13%) :arrow_down:
catalog ?
lambda 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 633 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 25 '23 10:09 codecov[bot]

braces alignment became more confusing

Ok, I'm not sure about this, so I'll revert it

fiskus avatar Sep 25 '23 13:09 fiskus